[Fixed]Terrain generation glitch

[CommanderABab]

The different depths look nice! It might be purposeful.

[Sometheotown mayor]

Not a glitch, look at the effect on the minimap

[Lobby]

I didn't expect such an issue, but you're right

[Sometheotown mayor]

That's not much of an issue, I think it looks nice

[Lobby]

It's a bug in a recent saving optimization of ground tiles.

For the optimization I packed the height (16 bit value) and surface slope heightDX, heightDY (each 8 bit values) into a single variable hxy:

Code: Select all

int hxy = &#40;height << 16&#41; | &#40;heightDX << 8&#41; | heightDY;

This code is absolutely fine, as long as heightDX and heightDY are not negative. If they are, they will be proceeded by 1s so the OR opteration will always yield 1s for the first 16 bits. This results in a height value of -1 after the next loading.

The solution is to apply masks so that proceeding bits will be cropped:

Code: Select all

int hxy = &#40;height << 16&#41; | &#40;&#40;heightDX << 8&#41; & 0xF0&#41; | &#40;heightDY & 0xF&#41;;

Unfortunately it's a saving problem and therefore cities which already have this issue will continue to have it.

[Sometheotown mayor]

*off topic*

Lobby I heard that you don't check the general discussion thread that often but please check it there's a message for you and Theo in it

Ty

*back to topic*
I didn't think it was a bug, I just thought it was like that to give an effect to the minimap

[Sometheotown mayor]

Yes I agree that when sudden, it doesn't look very good

Oh, then my info is wrong thank you

[AndrewIsCool1111]

I have the same problem, but I'm OK with it

[Ahmad Nur Aizat]

My old cities had these deep ocean trenches... I found few at Sedile

Maybe an option to customize our own ocean depths?

[Mayor Jeffrey IX]

same with me